httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Max Kellermann <...@duempel.org>
Subject [PATCH] fix off-by-one error in apreq_brigade_move()
Date Fri, 08 Jul 2005 13:03:18 GMT
Hi,

the function apreq_brigade_move() is bugged: it wants the "first
bucket after the move", but calls APR_RING_UNSPLICE() which wants the
"last element to unsplice".  This creates a off-by-one error which
shows up when you read the request body which was filtered by
mod_apreq: many buckets are lost.

A patch is included in this email. It simply passes the previous
bucket as right-hand limit.  I have commited it to svn, revision
209754.

Max


Mime
View raw message