httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: Massive leak in Apache2::Upload?
Date Wed, 08 Jun 2005 20:50:53 GMT
Markus Wichitill <mawic@gmx.de> writes:

> Joe Schaefer wrote:
>>     1) grab our svn trunk and apply the attached patch to it.
>>     2) make clean; make
>>     3) cd module; make test
>>     4) ls -l /tmp
>
> No files in /tmp.

WAG: see if this patch helps any

Index: library/util.c
===================================================================
--- library/util.c	(revision 171027)
+++ library/util.c	(working copy)
@@ -1171,14 +1171,14 @@
         return s;
 
     /* This cast, when out_len = -1, is intentional */
-    if ((apr_uint64_t)out_len < heap_limit) {
+    if ((apr_size_t)out_len < heap_limit) {
 
         s = apr_brigade_length(in, 0, &in_len);
         if (s != APR_SUCCESS)
             return s;
 
         /* This cast, when in_len = -1, is intentional */
-        if ((apr_uint64_t)in_len < heap_limit - (apr_uint64_t)out_len) {
+        if ((apr_size_t)in_len < heap_limit - (apr_size_t)out_len) {
             APR_BRIGADE_CONCAT(out, in);
             return APR_SUCCESS;
         }
@@ -1229,7 +1229,7 @@
          * temp_file bucket.
          */
 
-        while ((apr_uint64_t)wlen > FILE_BUCKET_LIMIT - last_out->length) {
+        while ((apr_size_t)wlen > FILE_BUCKET_LIMIT - last_out->length) {
             apr_bucket *e;
 
             apr_bucket_copy(last_out, &e);

-- 
Joe Schaefer


Mime
View raw message