httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject Re: libapreq2-2.05-dev-rc2 release candidate #2
Date Thu, 05 May 2005 06:01:39 GMT
On Wed, 4 May 2005, Joe Schaefer wrote:

> Randy Kobes <randy@theoryx5.uwinnipeg.ca> writes:
>
> > On Mon, 2 May 2005, Joe Schaefer wrote:
> >
> >> Please test and offer feedback on the second
> >> release candidate for libapreq2-2.05-dev.
> >
> > Builds and tests fine on Win32. I've put up a Win32 ppm
> > package of this (libapreq2) at
> >    http://theoryx5.uwinnipeg.ca/ppms/
> > which requires the mod_perl ppm package (RC5) from the
> > same location.
>
> Just rolled trunk as 2.05-dev to-be.  Committers please
> put some +1s down for this tarball + signature so I can
> announce the release tomorrow.  Thanks!
>
>     http://people.apache.org/~joes/libapreq2-2.05-dev.tar.gz
>     http://people.apache.org/~joes/libapreq2-2.05-dev.tar.gz.asc

The signature checks out fine for me. Unfortunately, I
missed one problem on Win32 in my earlier testing - the
subdirectory module/t/cgi-bin/ has to be created before
testing. If it's not too late, I could commit this fix:
==========================================================
Index: win32/test_cgi.mak
===================================================================
--- win32/test_cgi.mak	(revision 167861)
+++ win32/test_cgi.mak	(working copy)
@@ -51,7 +51,7 @@
 MODULE=$(APREQ_HOME)\module
 OUTDIR=$(CFG_HOME)\libs
 INTDIR=$(CFG_HOME)\libs
-
+CGIBIN=$(MODULE)\t\cgi-bin
 LINK32_OBJS= \
         "$(INTDIR)\test_cgi.obj" \
 	"$(OUTDIR)\libapreq2.lib" \
@@ -71,7 +71,7 @@
 BSC32=bscmake.exe
 BSC32_FLAGS=/nologo /o"$(OUTDIR)\test_cgi.bsc"
 LINK32=link.exe
-LINK32_FLAGS=kernel32.lib wsock32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib
shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib kernel32.lib user32.lib
gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib
odbc32.lib odbccp32.lib /nologo /subsystem:console /incremental:no /pdb:"$(OUTDIR)\test_cgi.pdb"
/machine:I386 /out:"$(MODULE)\t\cgi-bin\test_cgi.exe"
+LINK32_FLAGS=kernel32.lib wsock32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib
shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib kernel32.lib user32.lib
gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib
odbc32.lib odbccp32.lib /nologo /subsystem:console /incremental:no /pdb:"$(OUTDIR)\test_cgi.pdb"
/machine:I386 /out:"$(CGIBIN)\test_cgi.exe"

 !ELSEIF  "$(CFG)" == "test_cgi - Win32 Debug"

@@ -87,7 +87,7 @@
 BSC32=bscmake.exe
 BSC32_FLAGS=/nologo /o"$(OUTDIR)\test_cgi.bsc"
 LINK32=link.exe
-LINK32_FLAGS=kernel32.lib wsock32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib
shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib kernel32.lib user32.lib
gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib
odbc32.lib odbccp32.lib /nologo /subsystem:console /incremental:yes /pdb:"$(OUTDIR)\test_cgi.pdb"
/debug /machine:I386 /out:"$(MODULE)\t\cgi-bin\test_cgi.exe" /pdbtype:sept
+LINK32_FLAGS=kernel32.lib wsock32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib
shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib kernel32.lib user32.lib
gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib
odbc32.lib odbccp32.lib /nologo /subsystem:console /incremental:yes /pdb:"$(OUTDIR)\test_cgi.pdb"
/debug /machine:I386 /out:"$(CGIBIN)\test_cgi.exe" /pdbtype:sept

 !ENDIF

@@ -124,6 +124,7 @@
 <<

 "$(OUTDIR)\test_cgi.exe" : "$(OUTDIR)" $(DEF_FILE) $(LINK32_OBJS)
+    if not exist "$(CGIBIN)/$(NULL)" mkdir "$(CGIBIN)"
     $(LINK32) @<<
   $(LINK32_FLAGS) $(LINK32_OBJS)
 <<

==================================================================

However, I should have caught that before, so +1 if you'd
rather go ahead with this release.

-- 
best regards,
randy

Mime
View raw message