httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject Re: [apreq2] Win32 --debug
Date Thu, 05 May 2005 05:51:26 GMT
On Wed, 4 May 2005, Markus Wichitill wrote:

> The Win32 --debug parameter seems to have been lost
> lately, maybe during the make target consolidation:
>
> C:\Dev\debug\apreq-2.0>c:\dev\debug\perl\bin\perl Makefile.PL
> --with-apache2=c:\dev\debug\apache2 --debug
> perl: 5.8.6 ok
> Unknown option: debug
> mod_perl: 1.999024 ok
> [...]

Thanks for pointing this out - the following:
===========================================================
Index: Makefile.PL
===================================================================
--- Makefile.PL	(revision 167861)
+++ Makefile.PL	(working copy)
@@ -19,9 +19,10 @@
 undef @opts{qw(with-apache2-apxs with-apache1-apxs with-apache2-src
                with-perl with-apache2-httpd
                with-apr-config with-apu-config apxs)};
-undef $opts{'with-apache2'} if (WIN32);
+undef @opts{qw(with-apache2)} if (WIN32);

 my @flags = qw/enable-maintainer-mode enable-perl-glue disable-perl-glue/;
+push @flags, qw/debug/ if (WIN32);
 my %args;
 # grab from @ARGV only the options that we expect
 GetOptions(\%args, (map "$_=s", keys %opts), @flags);
@@ -39,6 +40,8 @@
     test_prereq "Test::More";
 }

+$opts .= "--debug " if (WIN32 and $args{debug});
+
 delete @args{@flags};
 $args{"with-apache2-apxs"} = delete $args{apxs}
     if exists $args{apxs} and not exists $args{"with-apache2-apxs"};
@@ -61,6 +64,7 @@
         }
     }
     my @opts = map{qq/--$_="$args{$_}"/} keys %args;
+    push @opts, (split ' ', $opts);
     my @args = (PERL_PATH, 'win32/Configure.pl', @opts);
     print "@args\n";
     system(@args) == 0 or die "system @args failed: $?";
Index: win32/Configure.pl
===================================================================
--- win32/Configure.pl	(revision 167861)
+++ win32/Configure.pl	(working copy)
@@ -11,13 +11,14 @@
 use Archive::Tar;
 use File::Path;
 use LWP::Simple;
-my ($apache, $debug, $help, $no_perl, $perl);
+my ($apache, $debug, $help, $no_perl, $perl, $with_perl);
 my $VERSION = '2.03-dev';
 my $result = GetOptions( 'with-apache2=s' => \$apache,
 			 'debug' => \$debug,
 			 'help' => \$help,
                          'with-perl=s' => \$perl,
                          'disable-perl-glue' => \$no_perl,
+                         'enable-perl-glue' => \$with_perl,
                        );
 usage() if $help;

==============================================================
should fix this.

-- 
best regards,
randy

Mime
View raw message