httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <pgollu...@p6m7g8.com>
Subject RE: [PATCH[ build/version_check.pl
Date Fri, 08 Apr 2005 07:56:07 GMT
Uwe Voelker wrote:

 >> And a sidenote to libapreq2: If libtool is not installed there is a
 >> misleading error message:
 >>
 >>  > ./buildconf
 >> removing stale config files
 >> checking buildconf prereqs
 >> build/version_check.pl failed: no version_string found in ''.
 >>
 >> Maybe it should output the name of programm it is testing (libtool in
 >> this case).

Hi, as promised, patch to output the tool in question.
It fixed a typo using $_ instead of $tool in the string

Index: build/version_check.pl
===================================================================
--- build/version_check.pl      (revision 160526)
+++ build/version_check.pl      (working copy)
@@ -133,7 +133,7 @@
   my @version = split /\./, $version;

   $_ = $prereq{$tool}->{test}->();
-die "$0 failed: no version_string found in '$_'.\n" unless /(\d[.\d]+)/;
+die "$0 failed: no version_string found in '$_' for '$tool'.\n" unless 
/(\d[.\d]+)/;
   my $saw = $1;
   my @saw = split /\./, $saw;
   $_ = 0 for @saw[@saw .. $#version]; # ensure @saw has enough entries

END
------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml

Mime
View raw message