httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Max Kellermann <...@duempel.org>
Subject [PATCH] apreq_quote() fixes and more
Date Thu, 28 Apr 2005 17:54:34 GMT
Hi,

the following patches are against trunk revision 165168 /
2.05-dev-rc1.

apreq-01-apr_brigade_length_returns_apr_off_t.patch
- resubmitted, original post from March 22nd (not applied yet)
- fix compiler error: apr_brigade_length() wants apr_off_t*, not
  apr_uint64_t

apreq-02-get_version_sh_with_SHELL.patch
- when build/get-version.sh is not executable, configure does not
  notice the error, but the build fails
- fix: run $SHELL build/get-version.sh

apreq-03-no_default_in_switch.patch
- another workaround for compiler warning: explicitly add cases for
  missing enum values, instead of default. Advantage: when we add
  another value and forget an implementation, we get a proper compiler
  warning

apreq-04-test_for_apreq_quote_once.patch
- add tests for apreq_quote() and apreq_quote_once()
- without the following patches, some of these fail, because the old
  implementation does not notice misplaced double quotes in the middle
  of the source string

apreq-05-null_terminate_dest.patch
- bugfix: null-terminate the return value in case the source string
  was already quoted

apreq-06-move_quoted_check_to_function.patch
- intermediate patch: move condition check to function is_quoted()

apreq-07-real_is_quoted_impl.patch
- really implement is_quoted(), checking for unescaped double quotes
  and for an escaped double quote at the end


I'm curious about the definition of apreq_quote(); it does not escape
backslashes, except when they are the last character, to prevent it
from escaping the double quote which will be appended. I think
apreq_quote() should quote all backslashes. The current behaviour is
inconsistent. Opinions?

Max


Mime
View raw message