httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: [PATCH multi-env] remove size() functions, empty string on n==0, apreq_fwritev() rewrite
Date Fri, 11 Mar 2005 03:03:16 GMT
Max Kellermann <max@duempel.org> writes:

> please review the last patch very carefully, because
> I havn't tested that

It looks ok to me after a quick scan.  I'll study it carefully
before committing it though.

> Another remark: error.c checks the apr_strerror() value for
> APR_EGENERAL. A message for that was not implemented until
> httpd 2.1, i.e. the test fails with httpd 2.0.53.

Ugh, that's bad.  How about we replace all APR_EGENERAL error
codes with APREQ_ERROR_GENERAL?

-- 
Joe Schaefer


Mime
View raw message