httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Max Kellermann <...@duempel.org>
Subject Re: [PATCH multi-env] remove size() functions, empty string on n==0, apreq_fwritev() rewrite
Date Fri, 11 Mar 2005 06:53:05 GMT
On 2005/03/11 04:03, Joe Schaefer <joe+gmane@sunstarsys.com> wrote:
> > Another remark: error.c checks the apr_strerror() value for
> > APR_EGENERAL. A message for that was not implemented until
> > httpd 2.1, i.e. the test fails with httpd 2.0.53.
> 
> Ugh, that's bad.  How about we replace all APR_EGENERAL error
> codes with APREQ_ERROR_GENERAL?

What's the difference between the two?

Disadvantage of custom status codes is that ap_log_rerror() can't
handle a custom libapreq status code correctly... or when some other
function is just passing a status code from libapreq to its caller,
which then handles it as "normal" APR status code.

So, is APREQ_ERROR_GENERAL really needed?

Max


Mime
View raw message