httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Max Kellermann <...@duempel.org>
Subject [PATCH multi-env] remove size() functions, empty string on n==0, apreq_fwritev() rewrite
Date Thu, 10 Mar 2005 23:30:21 GMT
04-remove_size_functions.patch
- remove apreq_param_size() and apreq_cookie_size()

05-remove_empty_string_on_n_eq_0.patch
- make apreq_join() and apreq_params_as_string() return an empty
  string on n==0

06-rewrite_fwritev.patch
- rewrite apreq_fwritev()
- no recursion; while(1) instead.
- optimization: eliminate one loop checking the whole iovec array
- check for endless loop (len == 0)

please review the last patch very carefully, because I havn't tested
that (writing a test for apreq_brigade_fwrite() is on my TODO list).

Another remark: error.c checks the apr_strerror() value for
APR_EGENERAL. A message for that was not implemented until httpd 2.1,
i.e. the test fails with httpd 2.0.53.

Max


Mime
View raw message