Return-Path: Delivered-To: apmail-httpd-apreq-dev-archive@www.apache.org Received: (qmail 74359 invoked from network); 17 Jan 2005 18:37:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 17 Jan 2005 18:37:20 -0000 Received: (qmail 79932 invoked by uid 500); 17 Jan 2005 18:37:19 -0000 Delivered-To: apmail-httpd-apreq-dev-archive@httpd.apache.org Received: (qmail 79906 invoked by uid 500); 17 Jan 2005 18:37:19 -0000 Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list apreq-dev@httpd.apache.org Received: (qmail 79890 invoked by uid 99); 17 Jan 2005 18:37:19 -0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of gcaa-apreq-dev@m.gmane.org designates 80.91.229.2 as permitted sender) Received: from main.gmane.org (HELO main.gmane.org) (80.91.229.2) by apache.org (qpsmtpd/0.28) with ESMTP; Mon, 17 Jan 2005 10:37:18 -0800 Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1CqbkX-0001UT-00 for ; Mon, 17 Jan 2005 19:37:13 +0100 Received: from adsl-3-9-33.mia.bellsouth.net ([65.3.9.33]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 17 Jan 2005 19:37:13 +0100 Received: from joe+gmane by adsl-3-9-33.mia.bellsouth.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 17 Jan 2005 19:37:13 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: apreq-dev@httpd.apache.org To: apreq-dev@httpd.apache.org From: Joe Schaefer Subject: Re: [apreq2] Apache::RequestRec::status overriden Date: Mon, 17 Jan 2005 13:37:06 -0500 Lines: 23 Message-ID: <87pt03ewbx.fsf@gemini.sunstarsys.com> References: <87y8esdlog.fsf@gemini.sunstarsys.com> <20050117180707.GA32070@roonstrasse.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: adsl-3-9-33.mia.bellsouth.net Mail-Copies-To: never User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) Cancel-Lock: sha1:aPn2a9jd2yYLrzrUrVfeBbXAowE= Sender: news X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Max Kellermann writes: > On 2005/01/17 18:12, Joe Schaefer wrote: >> Currently $r->status() means two different things: it's the server's >> response status when $r is an Apache::RequestRec obj, but it's the >> args+body parse status when $r is an Apache::Request object. > > Why does Apache::Request use Apache::RequestRec as base class? Mainly because in 1.x (both mod_perl and libapreq), Apache::Request used "Apache" as its base class. mod_perl 2.x renamed that class "Apache::RequestRec", because referring to the request_rec as "Apache" was a design mistake that they (quite happily) fixed. Personally I think it is also a design mistake for us to reuse the "Apache::Request" name (and mock the old 1.x @ISA relationship), when a much more appropriate name, "APR::Request", is readily available. If we went that route, all the @ISA kludges in our perl glue could (quite happily) go away, but mp1 users accustomed to the old 1.x @ISA relationship might be a bit disappointed in the change. -- Joe Schaefer