Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (hermes.apache.org: domain of gcaa-apreq-dev@m.gmane.org
 designates 80.91.229.2 as permitted sender)
Mail-Followup-To: apreq-dev@httpd.apache.org
To: apreq-dev@httpd.apache.org
From: Joe Schaefer <joe+gmane@sunstarsys.com>
Subject: Re: [PATCH] first snapshot of my "let's kill void*env" patch
Date: Sun, 09 Jan 2005 09:17:21 -0500
Lines: 28
Message-ID: <873bxa7klq.fsf@gemini.sunstarsys.com>
References: <20050107094434.GA28129@roonstrasse.net>
 <874qhta7dr.fsf@gemini.sunstarsys.com>
 <20050108205516.GA12181@roonstrasse.net>
 <87llb37f4j.fsf@gemini.sunstarsys.com>
 <Pine.LNX.4.56.0501081937390.21440@theoryx5.uwinnipeg.ca>
 <878y736w6c.fsf@gemini.sunstarsys.com>
 <20050109101429.GA14059@roonstrasse.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mail-Copies-To: never
User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux)
Cancel-Lock: sha1:9Pj51nyKdnDJP9a2rvo5D//yuy8=
Sender: news <news@sea.gmane.org>

Max Kellermann <max@duempel.org> writes:

> On 2005/01/09 05:52, Joe Schaefer <joe+gmane@sunstarsys.com> wrote:
>> The only obvious boo-boo I see in the patch (still haven't tested it
>> yet) is that httpd.h appears in src/apreq_apache2.h.  The src/ dir
>> must remain apr-only, but I think that file could go in env/.
>
> You were going around including httpd.h until now by casting
> request_rec* to void* ...

Yes, but we are also going around casting apr_pool_t* to void*
when running withing a CGI environment.  Whatever we put in
src/ cannot depend on httpd's API at all.

> I wasn't sure where to put that new include file. It belongs to
> mod_apreq.c; programs which don't use mod_apreq.c will not include
> apreq_apache2.h.

That can work.  I do like the concept, so I encourage you
to keep working on it.  Once you get this detail sorted out
and have all the t/ tests and env/t tests passing, post it
again and we'll kick it around some more.

But we do want to lock down the API real soon and start prepping
for a stable release, so don't make us wait too long ;-).

-- 
Joe Schaefer