Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (hermes.apache.org: local policy)
Message-ID: <41E6CD38.7080904@stason.org>
Date: Thu, 13 Jan 2005 14:34:16 -0500
From: Stas Bekman <stas@stason.org>
Organization: Hope, Humanized
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041217
MIME-Version: 1.0
To: Joe Schaefer <joe+gmane@sunstarsys.com>
Cc: apreq-dev@httpd.apache.org
Subject: Re: [patch] move Apache2 setup into a common file
References: <41E5FC5F.9030800@stason.org> <41E612D6.5070408@stason.org>
 <87u0plxn65.fsf@gemini.sunstarsys.com>
In-Reply-To: <87u0plxn65.fsf@gemini.sunstarsys.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Joe Schaefer wrote:
> Stas Bekman <stas@stason.org> writes:
> 
> [...]
> 
> 
>>As I've tweaked Makefile.PL and committed it, here it the latest
>>version: 
>>
>>Index: glue/perl/t/lib/TestApReq/DocSetup.pm
>>===================================================================
>>--- glue/perl/t/lib/TestApReq/DocSetup.pm	(revision 0)
>>+++ glue/perl/t/lib/TestApReq/DocSetup.pm	(revision 0)
>>@@ -0,0 +1,7 @@
>>+package TestApReq::DocSetup;
>>+
>>+# common things needed to run inlined doc tests go here
>>+
>>+use Apache2; # XXX: automate this
>>+
>>+1;

>>Index: glue/perl/docs/Upload.pod
>>===================================================================
>>--- glue/perl/docs/Upload.pod	(revision 125036)
>>+++ glue/perl/docs/Upload.pod	(working copy)
>>@@ -3,7 +3,7 @@
>>  Apache::Upload - Methods for dealing with file uploads.
>>
>>  =for testing
>>-    use Apache2;
>>+    use TestApReq::DocSetup;
> 
> 
> 
> I'll withhold my -1 (veto) on this, at least for a few days.
> But the show-stopper problem with this particular patch is
> that you have introduced a new dependency into our doc tests.
> So unless you also plan to install TestApReq::DocSetup somewhere,
> users will not be able to run the doc tests post-installation.

Well, you've asked me to how move the setup part out of the tests, and I 
did it in this way. You've never said those tests are going to be run 
post-install. I never thought that was the idea about Test::Inline.

Any a bit more than trivial testing environment requires a setup. If you 
need to duplicate this setup in every test, then you ask yourself whether 
the testing environment/tools you've chosen are good enough for you. But 
as I've said enough, I'm not sure whether the purpose of Test::Inline is 
to run tests after install. I thought it was rather about documenting and 
testing at the same time, as you develop the tool and has nothing to do 
with the user.

In any case, there is no need to veto anything, since this is not my itch, 
so if you don't like it that's fine.

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com