httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: [PATCH] second snapshot of my "let's kill void*env" patch
Date Thu, 20 Jan 2005 20:27:18 GMT
Max Kellermann <max@duempel.org> writes:

[...]

> Now which C standard is supported by Apache? Their documentation
> says ANSI, but that is apparently wrong. If they do not support ANSI
> C, it gives no advantage if we do.

The "Apache" standard, I guess ;-).  For better or worse, the basic goal 
for apreq-dev@ is to have our code compiling and running on every 
platform that httpd supports.  If their headers aren't ANSI compliant, 
then we need to drop that warning flag also.  I won't put the
"-isystem" thing into our build, so please try to find some
happy medium on the new warning flags.

And be sure to test them with --enable-maintainer-mode also, because 
that's what I use.  That should turn warnings into errors (-Werror),
and in your previous patch some of the "function not inlined" warnings 
prevented a full compile for me.

I use gcc-3.3, if it helps any.  Other folks may use the 2.9x version.
Other platforms may not use gcc at all.  We can accept tighter requirements
for --enable-maintainer-mode compiles, but an ordinary compile should 
try to be warnings-free on any supported platform.

-- 
Joe Schaefer


Mime
View raw message