httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: [patch] move Apache2 setup into a common file
Date Thu, 13 Jan 2005 17:18:42 GMT
Stas Bekman <stas@stason.org> writes:

[...]

> As I've tweaked Makefile.PL and committed it, here it the latest
> version: 
>
> Index: glue/perl/t/lib/TestApReq/DocSetup.pm
> ===================================================================
> --- glue/perl/t/lib/TestApReq/DocSetup.pm	(revision 0)
> +++ glue/perl/t/lib/TestApReq/DocSetup.pm	(revision 0)
> @@ -0,0 +1,7 @@
> +package TestApReq::DocSetup;
> +
> +# common things needed to run inlined doc tests go here
> +
> +use Apache2; # XXX: automate this
> +
> +1;
>
> Property changes on: glue/perl/t/lib/TestApReq/DocSetup.pm
> ___________________________________________________________________
> Name: svn:eol-style
>     + native
>
> Index: glue/perl/Makefile.PL
> ===================================================================
> --- glue/perl/Makefile.PL	(revision 125045)
> +++ glue/perl/Makefile.PL	(working copy)
> @@ -230,9 +230,10 @@
>
>       if ($test_docs) {
>           $string .= $test_docs;
> +        my $test_lib = catfile qw(t lib);
>           $string .= <<EOT;
>   doc_test : @tests
> -	\$(FULLPERLRUN) "-Mblib" "-MTest::Harness" "-e" "runtests(\@ARGV)" @tests
> +	\$(FULLPERLRUN) "-Mblib" "-I$test_lib" "-MTest::Harness" "-e"
> "runtests(\@ARGV)" @tests
>
>   test :: doc_test
>
> Index: glue/perl/docs/Upload.pod
> ===================================================================
> --- glue/perl/docs/Upload.pod	(revision 125036)
> +++ glue/perl/docs/Upload.pod	(working copy)
> @@ -3,7 +3,7 @@
>   Apache::Upload - Methods for dealing with file uploads.
>
>   =for testing
> -    use Apache2;
> +    use TestApReq::DocSetup;


I'll withhold my -1 (veto) on this, at least for a few days.
But the show-stopper problem with this particular patch is
that you have introduced a new dependency into our doc tests.
So unless you also plan to install TestApReq::DocSetup somewhere,
users will not be able to run the doc tests post-installation.

-- 
Joe Schaefer


Mime
View raw message