httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: [PATCH] first snapshot of my "let's kill void*env" patch
Date Sat, 08 Jan 2005 22:03:24 GMT
Max Kellermann <max@duempel.org> writes:

> Hi,
>
> I mentioned last week that I'm not satisfied with the current apreq2
> API, it has a number of flaws:
>
> - despite the vtable-like apreq_env_t struct, there can only be one
>   env module within a process

Correct.  What we are trying to do with apreq_env is to allow libapreq2
(and the perl glue) to work in different programming environments (CGI, 
Apache2.0, etc.).  We weren't really trying to do what you want it to
do, but maybe we should be.

> - to go around the "one env module only" limitation, there is a second
>   parameter in apreq_request() and apreq_cookie(), which lets the
>   caller specify a string to parse (which is not an elegant hack)

That's not quite the intent- mainly it was to create a "local"
apreq_request_t that's decoupled from the "shared" one associated
to the NULL argument.  That API is very hackish; I totally agree.

[...]

> Solution:

I'll comment more after I've reviewed it.  Anybody else out
there have an opinion?

Thanks, Max!

-- 
Joe Schaefer


Mime
View raw message