httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: [PATCH] first snapshot of my "let's kill void*env" patch
Date Sun, 09 Jan 2005 14:17:21 GMT
Max Kellermann <max@duempel.org> writes:

> On 2005/01/09 05:52, Joe Schaefer <joe+gmane@sunstarsys.com> wrote:
>> The only obvious boo-boo I see in the patch (still haven't tested it
>> yet) is that httpd.h appears in src/apreq_apache2.h.  The src/ dir
>> must remain apr-only, but I think that file could go in env/.
>
> You were going around including httpd.h until now by casting
> request_rec* to void* ...

Yes, but we are also going around casting apr_pool_t* to void*
when running withing a CGI environment.  Whatever we put in
src/ cannot depend on httpd's API at all.

> I wasn't sure where to put that new include file. It belongs to
> mod_apreq.c; programs which don't use mod_apreq.c will not include
> apreq_apache2.h.

That can work.  I do like the concept, so I encourage you
to keep working on it.  Once you get this detail sorted out
and have all the t/ tests and env/t tests passing, post it
again and we'll kick it around some more.

But we do want to lock down the API real soon and start prepping
for a stable release, so don't make us wait too long ;-).

-- 
Joe Schaefer


Mime
View raw message