httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Max Kellermann <>
Subject Re: [PATCH] second snapshot of my "let's kill void*env" patch
Date Thu, 13 Jan 2005 14:43:49 GMT
On 2005/01/13 15:19, Joe Schaefer <> wrote:
> A few points: the apr_tables we fetch things from are tables we create
> and control, so we know with certainty that dropping const causes 
> no harm.

What I dislike here most, is the fact that we provide a public
function which converts a "const char*" to an "apreq_value_t*" - I'd
prefer something where the compiler complains if you have made some
sort of obvious error like apreq_strtoval("a string literal"). But I
think we already agree on this.

> Let's leave this for another discussion.  If this is imporant to
> enought to you, to try working apreq_table_t (it's really a
> red-black tree with an apr_table_t like API) back into our codebase
> (IIRC there are still a few unresolved bugs in there, so it's not as
> stable as apr_table_t is).  I wouldn't have any trouble pushing that
> through to the perl glue for you.

Good idea.


View raw message