httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Max Kellermann <>
Subject Re: [PATCH] first snapshot of my "let's kill void*env" patch
Date Tue, 11 Jan 2005 18:42:04 GMT
On 2005/01/11 14:28, Joe Schaefer <> wrote:
> You can patch --enable-maintainer-mode to adjust CPPFLAGS; we have a
> few extra flags already there in acinclude.m4.

Why is that variable named CPPFLAGS? The preprocessor does not perform
warning checks, the compiler does. Should be CFLAGS.

btw, today I patched apreq to compile with nearly all warnings on:

-W -Wall -Werror -std=c99 -Wmissing-prototypes -Wwrite-strings
-Wcast-qual -Wfloat-equal -Wshadow -Wpointer-arith
-Wbad-function-cast -Wsign-compare -Waggregate-return
-Wmissing-declarations -Wmissing-noreturn -Wmissing-format-attribute
-Wpacked -Wredundant-decls -Wnested-externs -Winline
-Wdisabled-optimization -Wno-long-long -Wstrict-prototypes -Wundef
-pedantic-errors -Werror

I'll add all of them to CPPFLAGS. Let's raise the bar ;)

Tomorow will be the next release of my patch.


View raw message