httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bojan Smojver <bo...@rexursive.com>
Subject Re: [multi-env] privatizing apreq_request_t and apreq_jar_t
Date Fri, 28 Jan 2005 00:44:53 GMT
Quoting Joe Schaefer <joe+gmane@sunstarsys.com>:

> > while((status=ap_get_brigade(r->input_filters,brigade,
> >                              AP_MODE_READBYTES,APR_BLOCK_READ,
> >                              HUGE_STRING_LEN))!=APR_SUCCESS)
> >     ; /* nothing */
> >
> > Should actually do the work that ap_discard_request_body() does,
> > right? More or less, I mean.
>
> More or less. Actually the loop you wrote should segfault, because it's
> illegal to pass a non-empty brigade to ap_get_brigade.

I didn't include the part of code that creates an empty brigade. That's a bit
further up :-)

> I'd say it's the recommended approach for response handlers
> (the only folks truly authorized to throw away the post data).
> Everything else (auth handlers, output filters, etc.) should
> just ignore the spooling issues and just let libapreq2 work
> its magic.

OK, thanks.

--
Bojan

Mime
View raw message