httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject Re: DELCARE_HOOK|PARSER require NONSTD
Date Wed, 15 Dec 2004 03:36:52 GMT
On Tue, 14 Dec 2004, Joe Schaefer wrote:

> This patch drops the Win32 conditionals for
> APREQ_DECLARE_(PARSER|HOOK).  Since these functions
> are invoked internally through function pointers,
> the APREQ_DECLARE_NONSTD definition should be the
> correct declaration for all platforms.  Any
> objections to committing it?
>
> Index: src/apreq_params.h
> ===================================================================
> --- src/apreq_params.h	(revision 106989)
> +++ src/apreq_params.h	(working copy)
> @@ -232,24 +232,14 @@
>  /**
>   * Declares a API parser.
>   */
> -#ifndef WIN32
> -#define APREQ_DECLARE_PARSER(f) APREQ_DECLARE(apr_status_t) \
> -                                (f) (APREQ_PARSER_ARGS)
> -#else
>  #define APREQ_DECLARE_PARSER(f) APREQ_DECLARE_NONSTD(apr_status_t) \
>                                  (f) (APREQ_PARSER_ARGS)
> -#endif
>
>  /**
>   * Declares an API hook.
>   */
> -#ifndef WIN32
> -#define APREQ_DECLARE_HOOK(f)   APREQ_DECLARE(apr_status_t) \
> -                                (f) (APREQ_HOOK_ARGS)
> -#else
>  #define APREQ_DECLARE_HOOK(f)   APREQ_DECLARE_NONSTD(apr_status_t) \
>                                  (f) (APREQ_HOOK_ARGS)
> -#endif
>
>  /**
>   * Singly linked list of hooks.

+1 - it works for me, on both linux and Win32.

-- 
best regards,
randy

Mime
View raw message