Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Message-ID: <410D1277.4030401@gmx.de>
Date: Sun, 01 Aug 2004 17:55:35 +0200
From: Markus Wichitill <mawic@gmx.de>
User-Agent: Mozilla Thunderbird 0.7.2 (Windows/20040707)
MIME-Version: 1.0
To: Joe Schaefer <joe+gmane@sunstarsys.com>
CC: apreq-dev@httpd.apache.org
Subject: Re: Problem use Apache::Upload
References: <1091171298.4109f3e2f2210@webmail.vcsn.com>
 <410A38BD.7010207@gmx.de> <1091193034.410a48ca2ed08@webmail.vcsn.com>
 <410A4E0A.5000506@gmx.de> <1091195154.410a511229eea@webmail.vcsn.com>
 <410A5F6B.5080506@gmx.de> <87acxha49x.fsf@gemini.sunstarsys.com>
 <410A9CB1.8040702@gmx.de> <87hdrp8ei5.fsf@gemini.sunstarsys.com>
 <410ABD71.5070305@gmx.de> <87acxg86mj.fsf@gemini.sunstarsys.com>
In-Reply-To: <87acxg86mj.fsf@gemini.sunstarsys.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Joe Schaefer wrote:
> In your case (a content-handler using Apache::Request) 
> you should always call discard_request_body (not just for GET).
> The way to think of the discard_request_body call is
> 
>   "my content handler does not need the raw POST data,
>    so tell apache to pull it through the input 
>    filters via ap_get_brigade(), and then delete 
>    all the resulting buckets."

That sounds different from the RequestIO docs. So does the following make 
sense then?

[...]
if (MP) {
   $apr = Apache::Request->new($ap,
     POST_MAX => $cfg->{maxAttachLen},
     TEMP_DIR => $cfg->{attachFsPath},
   );

   $ap->discard_request_body() == 0
     or error("discard_request_body() failed.")
     if MP2;

   $apr->parse() == 0
     or error("Input exceeds maximum allowed size or is corrupted.")
     if $ap->method eq 'POST';
}
elsif (CGIAPR) {
   my $pool = APR::Pool->new();
   $apr = Apache::Request->new($pool,
     POST_MAX => $cfg->{maxAttachLen},
     TEMP_DIR => $cfg->{attachFsPath},
   );

   $apr->parse() == 0
     or error("Input exceeds maximum allowed size or is corrupted.")
     if $method eq 'POST';
}
elsif (CGI) {
[...]

I just want to make sure, because I'm getting upload errors with files of a 
specific size that I'm not getting without discard_request_body(). If the 
code should make sense, I'll post details about that.