httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: apreq_xs_tables.h w/o USE_ITHREADS
Date Thu, 05 Aug 2004 19:15:06 GMT
Randy Kobes <randy@theoryx5.uwinnipeg.ca> writes:

> In the latest cvs httpd-apreq-2 on a linux machine w/o
> USE_ITHREADS defined, I've run into a couple of problems in
> the perl glue, specifically with apreq_xs_tables.h. One
> problem, in apreq_xs_table_keys, is that *d is declared
> within an #ifdef USE_ITHREADS/#endif block, so should be
> moved out.  

+1.  It was originally put in there to evade a silly compiler
warning.  We now always require *d for the tainting mechanics, 
so it needs to come out of the ifdef.

> However, another problem is that both within
> APREQ_XS_DEFINE_TABLE_GET() and APREQ_XS_DEFINE_TABLE_DO, there's a
> dTHXa() call, which I think should be within #ifdef
> USE_ITHREADS/#endif. 

Why?  Doesn't our ppport.h header define this to dNOOP?

-- 
Joe Schaefer


Mime
View raw message