httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: cvs commit: httpd-apreq-2/src apreq_cookie.c
Date Sun, 25 Jul 2004 18:49:30 GMT
Stas Bekman <stas@stason.org> writes:

> joes@apache.org wrote:
> 
> >   Index: Cookie.pod
> 
> 
> >   +    $r = APR::Pool->new;
> >   +    $j = Apache::Cookie::Jar->new($r);
> 
> shouldn't that be $p? $r is confusing.

No, $p would be much worse.  99.999% of our users will
be using Apache::Request in mp2 not in CGI, where they
expect to pass $r.  Only the embedded tests require a pool- 
this code does not appear in any of the generated docs.

We could name it $env, since that's technically correct.
I wouldn't veto a change like that, although I wonder if
it will actually improve the docs from a user's standpoint.

-- 
Joe Schaefer


Mime
View raw message