httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: [apreq-2] make test fails
Date Fri, 02 Jul 2004 06:01:28 GMT
Joe Schaefer <joe+gmane@sunstarsys.com> writes:

> Joe Schaefer <joe+gmane@sunstarsys.com> writes:
> 
> [...]
> 
> > Looks like 6 params to me, but ...
> 
> [...]
> 
> > this says there were actually 4?  *Boggle*
> 
> Randy, see if this patch helps at all

[...oops, wrong do()...]

Sorry, sleepy.  Ignore the previous and try this

Index: src/apreq_params.c
===================================================================
RCS file: /home/cvs/httpd-apreq-2/src/apreq_params.c,v
retrieving revision 1.42
diff -u -r1.42 apreq_params.c
--- src/apreq_params.c  29 Jun 2004 18:34:48 -0000      1.42
+++ src/apreq_params.c  2 Jul 2004 05:58:16 -0000
@@ -148,13 +148,13 @@
     apr_array_header_t *arr = apr_array_make(p, apr_table_elts(req->args)->nelts,
                                              sizeof(apreq_param_t *));

-    apr_table_do(param_push, arr, req->args, key);
+    apr_table_do(param_push, arr, req->args, key, NULL);

     do s = apreq_env_read(req->env, APR_BLOCK_READ, APREQ_READ_AHEAD);
     while (s == APR_INCOMPLETE);

     if (req->body)
-        apr_table_do(param_push, arr, req->body, key);
+        apr_table_do(param_push, arr, req->body, key, NULL);

     return arr;
 }


va_arg is looks borked because our table_do list isn't
NULL-terminated in this situation.  We probably need
to fix that throughout.

-- 
Joe Schaefer


Mime
View raw message