httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject Re: Using mp2's APR::PerlIO and apr_perlio.h
Date Sat, 26 Jun 2004 20:25:35 GMT
On Sat, 26 Jun 2004, Joe Schaefer wrote:

> Randy Kobes <randy@theoryx5.uwinnipeg.ca> writes:
>
> > On Sat, 26 Jun 2004, Joe Schaefer wrote:
>
> [...]
>
> > > Is there a better way, or should I just go
> > > ahead and add the header file?
> >
> > I think it's relatively straightforward to add apr_perlio.h
> > to the list of header files mp2 installs into the
> > Apache2/include/ directory (eg, in mp2's top-level
> > Makefile.PL, add apr_perlio.h to the @xs_h_files array).
>
> That'll certainly work, however I don't want to hold up
> progress on apreq-dev while mp2 sorts this out.  Instead
> of adding the file, I'll just append the necessary declaration
> to apreq_xs_postperl.h.

Sounds good ... For future consideration, here's a diff
against the top-level mp2 Makefile.PL which will add
apr_perlio.h to the list of xs header files that get
installed under the Apache2 include/ directory.
=========================================================
Index: Makefile.PL
===================================================================
RCS file: /home/cvs/modperl-2.0/Makefile.PL,v
retrieving revision 1.139
diff -u -r1.139 Makefile.PL
--- Makefile.PL	26 Jun 2004 19:41:53 -0000	1.139
+++ Makefile.PL	26 Jun 2004 20:18:19 -0000
@@ -57,7 +57,8 @@
 # these h files need to be installed system-wide so 3rd party XS
 # extensions can use them
 my @xs_h_files = map catfile("xs", $_),
-    qw(modperl_xs_sv_convert.h modperl_xs_typedefs.h modperl_xs_util.h);
+    qw(modperl_xs_sv_convert.h modperl_xs_typedefs.h modperl_xs_util.h
+       APR/PerlIO/apr_perlio.h);

 my @exe_files =  map "bin/$_", qw(mp2doc mp2bug);

==================================================================

-- 
best regards,
randy

Mime
View raw message