httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject Re: [PATCH] Re: It's time to get 2.03-dev out
Date Tue, 08 Jun 2004 04:20:37 GMT
On Mon, 7 Jun 2004, Steve Hay wrote:

> Joe Schaefer wrote:
[ ... ]
> >It's likely due to a recent API change in mp2's APR::Bucket
> >(IIRC the return value of $b->read() used to be a status code).
> >What version of mp2 are you using?
> >
> 1.99_15-dev from a week or two ago, the Changes for which
> does indeed include:
>
> APR::Bucket: [Stas]
>   - read() now returns read data and throws APR::Error exception (not
> returning rc)
>
> So the test will have to check which version of mp2 is being used?  In
> the long term, you obviously want to use the new syntax, but clearly not
> many people are using it yet...

After upgrading my mod_perl to a more recent dev version, I
also find this failure. Does the following work?
=================================================================
Index: glue/perl/t/response/TestApreq/request.pm
===================================================================
RCS file: /home/cvs/httpd-apreq-2/glue/perl/t/response/TestApReq/request.pm,v
retrieving revision 1.7
diff -u -r1.7 request.pm
--- glue/perl/t/response/TestApreq/request.pm	28 Feb 2004 05:16:11 -0000	1.7
+++ glue/perl/t/response/TestApreq/request.pm	8 Jun 2004 04:13:09 -0000
@@ -7,6 +7,7 @@
 use Apache::RequestIO;
 use Apache::Request ();
 use Apache::Connection;
+require mod_perl;

 sub handler {
     my $r = shift;
@@ -26,7 +27,13 @@
 #        unlink("/home/joe/tmp/foo");
         my $bb = $upload->bb;
         while (my $b = $bb->first) {
-            $b->read(my $buffer);
+            my $buffer;
+            if ($mod_perl::VERSION < 1.9915) {
+                $b->read($buffer);
+            }
+            else {
+                $buffer = $b->read();
+            }
             $r->print($buffer);
             $b->remove;
         }
===================================================================

-- 
best regards,
randy

Mime
View raw message