httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [PATCH] Re: It's time to get 2.03-dev out
Date Tue, 08 Jun 2004 13:27:14 GMT
Randy Kobes wrote:
> On Mon, 7 Jun 2004, Steve Hay wrote:
> 
> 
>>Joe Schaefer wrote:
> 
> [ ... ]
> 
>>>It's likely due to a recent API change in mp2's APR::Bucket
>>>(IIRC the return value of $b->read() used to be a status code).
>>>What version of mp2 are you using?
>>>
>>
>>1.99_15-dev from a week or two ago, the Changes for which
>>does indeed include:
>>
>>APR::Bucket: [Stas]
>>  - read() now returns read data and throws APR::Error exception (not
>>returning rc)
>>
>>So the test will have to check which version of mp2 is being used?  In
>>the long term, you obviously want to use the new syntax, but clearly not
>>many people are using it yet...

I'm still trying to find the best solution. I think I'm going back to the

   $b->read(my $buffer)

syntax, but use the exception in the void context approach. so please don't 
rush changing things, just yet.

I wish I was getting feedback on those API changes, when I propose them. 
Without such I just talk to myself, so some of the API go back and forth as I 
write new code and find the changes to be not so good.

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Mime
View raw message