httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Hay <steve....@uk.radan.com>
Subject Re: [PATCH] Re: It's time to get 2.03-dev out
Date Mon, 07 Jun 2004 13:39:05 GMT
Joe Schaefer wrote:

>Steve Hay <steve.hay@uk.radan.com> writes:
>
>[...]
>
>  
>
>>I'm struggling to find the necessary docs to look at.  I think $b here 
>>is an APR::Brigade, 
>>    
>>
>
>No, $b is an APR::Bucket; $bb is an APR::Brigade.
>
That makes sense, then.

>
>  
>
>>Maybe APR::Bucket?  That has a read() which takes an optional "mode" 
>>parameter (numeric?), and /returns/ the data read, so I tried this:
>>
>>            my $buffer = $b->read();
>>
>>and now it's all OK.
>>
>>So the following patch fixes this for me, but I'm very confused how 
>>nobody else could have noticed this?
>>    
>>
>
>It's likely due to a recent API change in mp2's APR::Bucket
>(IIRC the return value of $b->read() used to be a status code).  
>What version of mp2 are you using?
>
1.99_15-dev from a week or two ago, the Changes for which does indeed 
include:

APR::Bucket: [Stas]
  - read() now returns read data and throws APR::Error exception (not 
returning rc)

So the test will have to check which version of mp2 is being used?  In 
the long term, you obviously want to use the new syntax, but clearly not 
many people are using it yet...

- Steve



------------------------------------------------
Radan Computational Ltd.

The information contained in this message and any files transmitted with it are confidential
and intended for the addressee(s) only.  If you have received this message in error or there
are any problems, please notify the sender immediately.  The unauthorized use, disclosure,
copying or alteration of this message is strictly forbidden.  Note that any views or opinions
presented in this email are solely those of the author and do not necessarily represent those
of Radan Computational Ltd.  The recipient(s) of this message should check it and any attached
files for viruses: Radan Computational will accept no liability for any damage caused by any
virus transmitted by this email.


Mime
View raw message