httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: cvs commit: httpd-apreq-2/glue/perl/xsbuilder/Apache/Request Request_pm
Date Mon, 05 Apr 2004 23:51:14 GMT
Joe Schaefer wrote:
> Stas Bekman <stas@stason.org> writes:
> 
> 
>>>  -if (\$ENV{MOD_PERL}) {
>>>  +if ($ENV{MOD_PERL}) {
>>>       require mod_perl;
>>>  -    if (\$mod_perl::VERSION > 1.99) {
>>>  +    my $env = __PACKAGE__->env || '';
>>>  +    if ($mod_perl::VERSION > 1.99) {
>>>           die __PACKAGE__ . ": httpd must load mod_apreq.so first"
>>>  -               if __PACKAGE__->env ne "Apache::RequestRec";
>>>  +               if $env ne "Apache::RequestRec";
>>>       }
>>>  -    elsif (\$mod_perl::VERSION > 1.24) {
>>>  +    elsif ($mod_perl::VERSION > 1.24) {
>>>           die __PACKAGE__ . ": httpd must load mod_apreq1.so first"
>>>  -              if __PACKAGE__->env ne "Apache";
>>>  +              if $env ne "Apache";
>>
>>Why are we dealing with apreq1 in apreq2, again?
> 
> 
> I'm not sure what you're asking about here, but the code 
> in question was part of the plan to backport apreq2's Perl API
> to apache-1.3.  If you want to take it out, I won't object
> since I'm not going to devote any more time to that effort.

I remember that. The reason I've asked is that we use things like:

   use warnings FATAL => 'all';

which is not available for perl < 5.6. So as long as we stick with mp2, we 
know that we run 5.6.1+ and that syntax is fine. If not, then we either can't 
use it or need to install some backcompat wrapper like Apache-Test does.

But I think we should nuke that 1.x part while we don't support 1.x, since 
it'll only confuse users if they get to load Apache::Request built for mp1 
from their mp2 server.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Mime
View raw message