httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward J. Sabol" <sa...@alderaan.gsfc.nasa.gov>
Subject Re: libapreq2-2.02-dev build problems with Perl 5.6.1
Date Wed, 25 Feb 2004 22:33:31 GMT
>> I strongly suggest updating the minimum version requirement for libtool
>
> After some googling around, I don't think upping the libtool version is
> appropriate here. AM_PROG_LIBTOOL has been around for a while, but we
> may be better off if we use AC_PROG_LIBTOOL instead.

*shrug* All I know is that it didn't work with libtool 1.4.2 and it did work
after I upgraded to libtool 1.5.2. However, I just uninstalled libtool 1.5.2
and tried it again with libtool 1.4.2 and it seemed to work. I upgraded
automake right before I upgraded libtool, so maybe that is related.

>> I suspect $(top_builddir) isn't getting set in the "recheck", but I
>> haven't looked at the Makefile that closely.
>
> OK. See if the following patch to acinclude.m4 helps any:

That cleared up all but one of the buildconf warnings and it fixed the
problem with $(top_builddir) and "recheck".

The following amended patch also eliminates the other buildconf warning about
AC_APREQ being "underquoted":

Index: acinclude.m4
===================================================================
RCS file: /home/cvspublic/httpd-apreq-2/acinclude.m4,v
retrieving revision 1.15
diff -u -r1.15 acinclude.m4
--- acinclude.m4        7 Nov 2003 20:40:49 -0000       1.15
+++ acinclude.m4        25 Feb 2004 21:58:18 -0000
@@ -1,4 +1,4 @@
-AC_DEFUN(AC_APREQ, [
+AC_DEFUN([AC_APREQ], [
 
         AC_ARG_ENABLE(perl_glue,
                 AC_HELP_STRING([--enable-perl-glue],[build perl modules Apache::Request and
Apache::Cookie]),
@@ -103,9 +103,9 @@
           USE_VPATH=1
         fi
 
-        AC_SUBST(top_builddir)
-        AC_SUBST(abs_srcdir)
-        AC_SUBST(abs_builddir)
+        dnl AC_SUBST(top_builddir)
+        dnl AC_SUBST(abs_srcdir)
+        dnl AC_SUBST(abs_builddir)
 
         get_version="$abs_srcdir/build/get-version.sh"
         version_hdr="$abs_srcdir/src/apreq_version.h"
@@ -147,7 +147,7 @@
         AC_SUBST(PERL)
 ])
 
-AC_DEFUN(APR_ADDTO,[
+AC_DEFUN([APR_ADDTO],[
   if test "x$$1" = "x"; then
     echo "  setting $1 to \"$2\""
     $1="$2"

Mime
View raw message