httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: [ANN] libapreq2-2.01-dev-rc1 release candidate #1
Date Fri, 07 Nov 2003 01:57:36 GMT
Joe Schaefer <joe+gmane@sunstarsys.com> writes:

> Vladimir Dudov <dudov@relexus.com> writes:
> 
> > apreq_filter() should always return APR_SUCCESS no matter what
> > internal fuctions (like apreq_parse_request()) have done.
> 
> That's a bit too drastic, IMO;  the filter needs to
> report parsing errors to ap_get_brigade when they occur.  

Hmm, after mulling this over a bit more, maybe you're right 
after all.  The paradigm we've tried to follow was for mod_apreq be a
transparent "tee", so parsing errors are probably inappropriate
return values.

> See if this patch works:

I'm still curious if the patch works or not.

-- 
Joe Schaefer


Mime
View raw message