httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: [ANN] libapreq2-2.01-dev-rc1 release candidate #1
Date Fri, 07 Nov 2003 01:01:13 GMT
Vladimir Dudov <dudov@relexus.com> writes:

> apreq_filter() should always return APR_SUCCESS no matter what
> internal fuctions (like apreq_parse_request()) have done.

That's a bit too drastic, IMO;  the filter needs to
report parsing errors to ap_get_brigade when they occur.  

See if this patch works:

Index: env/mod_apreq.c
===================================================================
RCS file: /home/cvs/httpd-apreq-2/env/mod_apreq.c,v
retrieving revision 1.36
diff -u -r1.36 mod_apreq.c
--- env/mod_apreq.c	31 Oct 2003 20:50:18 -0000	1.36
+++ env/mod_apreq.c	7 Nov 2003 00:59:21 -0000
@@ -444,7 +444,8 @@
         return ctx->status;
 
     ctx->status = apreq_parse_request(req, ctx->bb);
-    return (ctx->status == APR_INCOMPLETE) ? APR_SUCCESS : ctx->status;
+    return (ctx->status == APR_INCOMPLETE || ctx->status == APR_EINIT) 
+        ? APR_SUCCESS : ctx->status;
 }
 
 static APREQ_ENV_MODULE(apache2, APREQ_MODULE_NAME,

-- 
Joe Schaefer


Mime
View raw message