httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject Re: cvs commit: httpd-apreq-2/env/t/cgi-bin .cvsignore
Date Fri, 24 Oct 2003 05:01:59 GMT
On Thu, 24 Oct 2003, Joe Schaefer wrote:

> randyk@apache.org writes:
>
> > randyk      2003/10/23 16:58:15
> >
> >   Modified:    env      Makefile.am .cvsignore
> >   Added:       env      test_cgi.c
> >                env/t    cgi.t
> >                env/t/conf extra.conf.in
> >                env/t/cgi-bin .cvsignore
> >   Log:
> >   add libapreq_cgi tests.
>
> After the Marlins big win tonight,

It's not the same since the Blue Jays fell into disrepair :)

>  I had some problems running the
> tests with apr's current cvs- apr_env_get's behavior may have changed
> slightly, and I was getting segfaults on cgi tests 1-9. Initializing
> value = NULL took care of those.  Also test 22 uses GET_BODY with a
> "Content" argument; I'm not sure if that's legit or not, so I changed
> it to POST_BODY.

Sorry about that - that was a remnant of me switching back
and forth betwen GET and POST when there were problems under
env/t/, which you fixed ...

> The last criticism is that we should eventually get rid of the
> env_ctx struct in test_cgi.c, and use a static global variable in
> libapreq_cgi instead.  There's no natural candidate for "env" in a cgi
> context, so IMO we should probably ignore all the "env" arguments and
> let users put anything they like in that slot.
>
> Anyways, for now here's the diff from env/ that fixes the segfaults.
> Let me know if it works ok.

It works fine for me under Win32 ... Thanks.

-- 
best regards,
randy

Mime
View raw message