httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: cvs commit: httpd-apreq-2/build xsbuilder.pl
Date Thu, 30 Oct 2003 06:47:45 GMT
joes@apache.org wrote:
> joes        2003/10/29 20:45:52
> 
>   Modified:    build    xsbuilder.pl
>   Log:
>   Improve the perl glue's environment check by following the recipe in CGI.pm
>   
>   Revision  Changes    Path
>   1.18      +14 -2     httpd-apreq-2/build/xsbuilder.pl
>   
>   Index: xsbuilder.pl
>   ===================================================================
>   RCS file: /home/cvs/httpd-apreq-2/build/xsbuilder.pl,v
>   retrieving revision 1.17
>   retrieving revision 1.18
>   diff -u -r1.17 -r1.18
>   --- xsbuilder.pl	30 Oct 2003 01:22:00 -0000	1.17
>   +++ xsbuilder.pl	30 Oct 2003 04:45:52 -0000	1.18
>   @@ -237,8 +237,20 @@
>    # The modperl package isn't necessarily loaded, but Apache2
>    # is.  Perhaps Apache2 should always include a VERSION?

No, it shouldn't. If it does people will start using it in their code
to check for version which won't work when mp3 comes out.

>   -die __PACKAGE__ . ": httpd must load mod_apreq.so first"
>   -           if __PACKAGE__->env ne "Apache::RequestRec";
>   +if (\$ENV{MOD_PERL}) {
>   +    require mod_perl;
>   +    if (\$mod_perl::VERSION > 1.99) {
>   +        die __PACKAGE__ . ": httpd must load mod_apreq.so first"
>   +               if __PACKAGE__->env ne "Apache::RequestRec";
>   +    }
>   +    elsif (\$mod_perl::VERSION > 1.24) {
>   +        die __PACKAGE__ . ": httpd must load mod_apreq1.so first"
>   +              if __PACKAGE__->env ne "Apache";

A::R 2 supports mp1?

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Mime
View raw message