Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Organisation: Radan Computational Ltd., Bath, UK.
Phone: +44 1225 320320   Fax: +44 1225 320311
Web: http://www.radan.com/
Message-ID: <3F45C519.6050704@uk.radan.com>
Date: Fri, 22 Aug 2003 08:24:09 +0100
From: Steve Hay <steve.hay@uk.radan.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.4) Gecko/20030624 Netscape/7.1 (ax)
MIME-Version: 1.0
To: Joe Schaefer <joe+gmane@sunstarsys.com>
CC: Stas Bekman <stas@stason.org>, apreq-dev@httpd.apache.org
Subject: Re: [PATCH] Fix building libapreq-1.2 with latest
 ExtUtils-MakeMaker's
References: <3F44A3C8.4020209@uk.radan.com>
	<m3he4bfb3k.fsf@sol.sunstarsys.com> <3F44FA26.2000507@stason.org>
 <m3d6eyg80j.fsf@sol.sunstarsys.com>
In-Reply-To: <m3d6eyg80j.fsf@sol.sunstarsys.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Joe Schaefer wrote:

>Stas Bekman <stas@stason.org> writes:
>
>  
>
>>Not, so fast. Won't it break the hack for older perls with older
>>MakeMaker?
>>    
>>
>
>It shouldn't- for older MakeMakers it should have the same effect
>as the current code.  At least that's my impression of the discussion
>to date.
>
I agree.  To quote Schwern in his original suggestion:

===
6.05 and previous had this:

dynamic :: Makefile $(INST_DYNAMIC) $(INST_BOOT)

6.06_01 and up have this

dynamic :: $(FIRST_MAKEFILE) $(INST_DYNAMIC) $(INST_BOOT)
===

The patch changed a substitution that was looking for the bit to keep 
("Makefile" or "$(FIRST_MAKEFILE)", which changed) to a pair of 
substitutions looking for the bits to lop off ("$(INST_DYNAMIC)" and 
"$(INST_BOOT)", which didn't change), so it should be fine.