httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: libapreq failures with 1.2 and Mac OS X Server
Date Thu, 14 Aug 2003 00:28:02 GMT
David Wheeler wrote:
> On Wednesday, August 13, 2003, at 03:55  PM, Chris Nandor wrote:
> 
>> As long as having it in there twice won't hurt anything (in case someone
>> defined it on the command line), it seems right to me.
> 
> 
> 
> --- Makefile.PL Tue Jul  1 22:04:06 2003
> +++ /Users/david/Desktop/Makefile.PL    Wed Aug 13 16:10:32 2003
> @@ -197,6 +197,7 @@
>  $WITH_APXS = "";
>  $APACI_ARGS = "";
>  @APACI_ARGS = ();
> +push @APACI_ARGS, '--without-execstrip' if $^O eq 'darwin';
>  $EVERYTHING = $EXPERIMENTAL = 0;
>  $PERL_DEBUG = "";
>  $PERL_DESTRUCT_LEVEL = "";
> @@ -323,7 +324,9 @@
>         close $fh;
>      }
>      if(@APACI_ARGS) {
> -       unshift @ARGV, "APACI_ARGS=" . join(",", @APACI_ARGS);
> +        my %seen;
> +       unshift @ARGV, "APACI_ARGS=" .
> +          join ',', grep { not $seen{$_}++ } @APACI_ARGS;
>      }
>  }

I'm not sure whether this won't break something. Is it possible that someone 
will want to pass one option more than once intentionally? In that case it's 
probably better to do:

@APACI_ARGS = ();
...
if(@APACI_ARGS) {
   if($^O eq 'darwin') {
     push @APACI_ARGS, '--without-execstrip'
       unless scalar grep /^--without-execstrip$/, @APACI_ARGS;
   }
   unshift @ARGV, "APACI_ARGS=" . join(",", @APACI_ARGS);
}

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Mime
View raw message