httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: [ANNOUNCE] mod_perl-1.28
Date Fri, 04 Jul 2003 21:43:33 GMT

[lists trimmed to apreq-dev]

Steve Hay <steve.hay@uk.radan.com> writes:

> Hi Randy,

[...]

> Yes, this fixes it for me.

> Randy Kobes wrote:

> >============================================================
> >Index: Request/Request.xs
> >===================================================================
> >RCS file: /home/cvs/httpd-apreq/Request/Request.xs,v
> >retrieving revision 1.36
> >diff -u -r1.36 Request.xs
> >--- Request/Request.xs	25 Jun 2003 07:59:37 -0000	1.36
> >+++ Request/Request.xs	4 Jul 2003 05:32:59 -0000
> >@@ -533,7 +533,7 @@
> >     if (fd < 0)
> >         XSRETURN_UNDEF;
> >
> >-    if ( !(RETVAL = PerlIO_fdopen(fd, "r")) )
> >+    if ( !(RETVAL = PerlIO_fdopen(fd, "rb")) )
> > 	XSRETURN_UNDEF;
> > #else
> >     if (  ( RETVAL = PerlIO_importFILE(fp,0) ) == NULL  )
> >@@ -558,7 +558,7 @@
> > 	PerlIO *fp;
> >
> > 	fd = PerlLIO_dup(fd);
> >-	if (!(fp = PerlIO_fdopen(fd, "r"))) {
> >+        if (!(fp = PerlIO_fdopen(fd, "rb"))) {
> > 	    PerlLIO_close(fd);
> > 	    croak("fdopen failed!");
> > 	}
> >========================================================

The patch looks good to me.  Please commit,
with a patch to Changes that notes the bugfix.
Hmm, maybe we should do a 1.3 release before
attempting 2.0-dev?

-- 
Joe Schaefer


Mime
View raw message