httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: bug in ApacheRequest_parse macro
Date Wed, 09 Jul 2003 23:38:08 GMT
Graham Clark <gcla@dcs.ed.ac.uk> writes:

> Hi,
> 
> There seems to be a minor bug in apache_request.h when a dereferenced
> argument is supplied to this macro - how about the following simple
> patch? (Hope I've checked the latest version!)

[...]

>  #define ApacheRequest_parse(req) \
> -    (req->status = req->parsed ? req->status : ApacheRequest___parse(req))
> +    ((req)->status = (req)->parsed ? (req)->status : \
> +                                         ApacheRequest___parse(req))  

Thanks!  So the bug is caused by the missing parens for req, 
right? Hmm, what about the other #define's in apache_request.h?  
Shouldn't we fix those also?

-- 
Joe Schaefer


Mime
View raw message