httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+apa...@sunstarsys.com>
Subject Re: [PATCH] to accept file uploads from Nokia Series 60 phones
Date Sun, 13 Apr 2003 16:13:53 GMT
"Oskari 'Okko' Ojala" <sorter.apreq.apache.org@okko.net> writes:

[...excellent summary...]

> --- apache_request_rev1.23.c    Sun Apr 13 13:47:35 2003
> +++ apache_request.c    Sun Apr 13 13:48:31 2003
> @@ -568,7 +568,7 @@
>               if(strEQ(key, "name")) {
>                   param = ap_getword_conf(r->pool, &pair);
>               }
> -             else if(strEQ(key, "filename")) {
> +             else if(strEQ(key, "filename") || strEQ(key, "Filename")) {
>                   filename = ap_getword_conf(r->pool, &pair);
>               }
>           }

Thanks alot!  I'm +1 for having this functionality in libapreq-1.2, 
but perhaps we should be using a case-insensitive test (like strcasecmp)
instead of strEQ in this section of code.

[...]

> Other information:
> 
> RFC 2388 says:
>    The original local file name may be supplied as well, either as a
>    "filename" parameter either of the "content-disposition: form-data"
>    header or, in the case of multiple files, in a "content-disposition:
>    file" header of the subpart.

We actually don't have any code for handling the "multiple files" case
mentioned above.  I think that's a feature best reserved for httpd-apreq-2.
It should be pretty straightforward to modify/reuse apreq_parse_multipart() 
to generate a brigade which represents the "multiple files" case.  The
apreq-2 parsers are all reentrant (hopefully :-).

> A caption of an IE POST with a file upload:
> 
> Content-Disposition: form-data; name="ImageData"; filename="Photo(21).jpg"
> Content-Type: image/bmp
                ^^^^^^^^^                                               ^^^

Interesting- the Content-Type appears to be incorrect here, no?
Good luck on submitting a bugfix to M$ :-).

Thanks again!
-- 
Joe Schaefer

Mime
View raw message