httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: are there only M_POST and M_GET/HEAD?
Date Fri, 19 Apr 2002 15:46:26 GMT
Joe Schaefer wrote:
> Stas Bekman <stas@stason.org> writes:
> 
> [...]
> 
> 
>>Moreover ApacheRequest_parse_urlencoded does anything at all only if
>>the method is POST, so why do we call it? looks like a bad logic to
>>me.
> 
> 
> It is.  Someone else brought this up on the list about a month ago.
> Post a diff ( "cvs diff" inside the httpd-apreq directory) so folks 
> can test your proposed changes.

sure, here it is:

this call is useless.

Index: c/apache_request.c
===================================================================
RCS file: /home/cvs/httpd-apreq/c/apache_request.c,v
retrieving revision 1.20
diff -u -r1.20 apache_request.c
--- c/apache_request.c	18 Feb 2002 16:48:27 -0000	1.20
+++ c/apache_request.c	19 Apr 2002 15:45:20 -0000
@@ -290,9 +290,6 @@
  	    result = HTTP_INTERNAL_SERVER_ERROR;
  	}
      }
-    else {
- 
result = ApacheRequest_parse_urlencoded(req);
-    }



__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Mime
View raw message