httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject a missing while block runs the next statement?
Date Fri, 19 Apr 2002 10:47:49 GMT
I think this patch is needed. Otherwise to me it looks like we have:

   ap_hard_timeout(...)
   while (...) {
       ap_kill_timeout(...);
   }

or was this intentional and therefore the indent is wrong?

while porting, I'm enforcing explicit {} everywhere per apache style.

Index: c/apache_request.c
===================================================================
RCS file: /home/cvs/httpd-apreq/c/apache_request.c,v
retrieving revision 1.20
diff -u -r1.20 apache_request.c
--- c/apache_request.c	18 Feb 2002 16:48:27 -0000	1.20
+++ c/apache_request.c	19 Apr 2002 10:44:07 -0000
@@ -420,8 +420,9 @@
  		      "[libapreq] silently drop remaining '%ld' bytes", r->remaining);
  #endif
              ap_hard_timeout("[libapreq] parse_multipart", r);
-            while ( ap_get_client_block(r, buff, sizeof(buff)) > 0 )
+            while ( ap_get_client_block(r, buff, sizeof(buff)) > 0 ) {
                  /* wait for more input to ignore */ ;
+            }
              ap_kill_timeout(r);
  	    return OK;
  	}


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Mime
View raw message