httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craig McLane <ccmcl...@yahoo.com>
Subject Re: apache_request.c: ApacheRequest___parse
Date Sun, 17 Mar 2002 17:22:44 GMT
Joe,
Thanks for the quick reply.  To be honest, I noticed the possible
duplication and whipped up a quick patch, but I haven't tested it.

Craig



--- Joe Schaefer <joe+apache@sunstarsys.com> wrote:
> Craig McLane <ccmclane@yahoo.com> writes:
> 
> > --- libapreq-1.0/c/apache_request.c	Mon Feb 18 08:48:27 2002
> > +++ libapreq-1.0-ccm/c/apache_request.c	Sat Mar 16 09:54:19 2002
> > @@ -270,7 +270,7 @@
> >  int ApacheRequest___parse(ApacheRequest *req)
> >  {
> >      request_rec *r = req->r;
> > -    int result;
> > +    int result = OK;
> >  
> >      if (r->args) {
> >          split_to_parms(req, r->args);
> > @@ -289,9 +289,6 @@
> >  			  "[libapreq] unknown content-type: `%s'", ct);
> >  	    result = HTTP_INTERNAL_SERVER_ERROR;
> >  	}
> > -    }
> > -    else {
> > -	result = ApacheRequest_parse_urlencoded(req);
> >      }
> >  
> >      req->parsed = 1;
> 
> Your patch looks OK to me.  Have you tested it?
> 
> -- 
> Joe Schaefer


__________________________________________________
Do You Yahoo!?
Yahoo! Sports - live college hoops coverage
http://sports.yahoo.com/

Mime
View raw message