Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
To: apreq-dev@httpd.apache.org
Cc: "Stathy Touloumis" <stathy.touloumis@edventions.com>
Subject: 5005thread patch (was Re: make failure for Apache::Request)
References: <NEBBJNOCEMFNCMPFPHCNEEDGCEAA.stathy.touloumis@edventions.com>
From: Joe Schaefer <joe@sunstarsys.com>
Date: 08 Jan 2002 01:11:23 -0500
In-Reply-To: "Stathy Touloumis"'s message of "Mon, 7 Jan 2002 10:31:43 -0600"
Message-ID: <m3advps778.fsf@mumonkan.sunstarsys.com>
Lines: 46
User-Agent: Gnus/5.0802 (Gnus v5.8.2) Emacs/20.5
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii


[message forwarded to apreq-dev@httpd.apache.org - some content trimmed]

"Stathy Touloumis" <stathy.touloumis@edventions.com> writes:

> Hi,
> 
> I wasn't able to send an email to apreq-dev@apache.org, kept bouncing back.
> I thought I would forward it to you in case you might be able to help.
> 
> I was able to perform a successful build for libapreq-0.33 on :
> #uname -a
> Linux notebook 2.4.10 #1 Sun Dec 9 16:35:07 CST 2001 i686 unknown
> 
> The patch is below in 'unified' format.  Please let me know if there is
> documentation on standards for submitting patches etc.
> 
> Thanks : )
> 
> #perl -V

[...]

>     usethreads=define use5005threads=define useithreads=undef

[...]

> #diff -u Request.xs.OLD Request.xs
> --- Request.xs.OLD      Mon Jan  7 11:07:51 2002
> +++ Request.xs  Mon Jan  7 11:06:08 2002
> @@ -192,6 +192,7 @@
> 
>  static int upload_hook(void *ptr, char *buf, int len, ApacheUpload *upload)
>  {
> +       dTHX;
>      UploadHook *hook = (UploadHook *)ptr;
> 
>      if (!(upload->fp && ApacheRequest_tmpfile(upload->req, upload))) {

Thanks, will apply shortly.  Maybe we should also bundle some feature
tests (using Apache::test?) before going to 1.0?  Perhaps we should try 
adding some of the mod_perl test suite to (the perl portion of) libapreq.

Thoughts, anyone?
-- 
Joe Schaefer