httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Issac Goldstand" <mar...@beamartyr.net>
Subject Re: 5005thread patch (was Re: make failure for Apache::Request)
Date Tue, 08 Jan 2002 06:17:31 GMT
If tests are to be added, lets try to improve on the httpd portion of it.
Apache::SSI's suite, for example, NEVER works for me when I have DSOs on my
server.  mod_perl doesn't even support the test suite for a DSO (at least
not when built via apxs).  IMHO, the first step towards doing this would be
to make an Apache::Test or Test::Apache module (namespace varying based on
how you look at it's functionality - I personally think Test::Apache is more
appropriate, simply because it shows that the module is part of Test, and
not another mod_perl module).  I'm not voulenteering, mostly for lack of
time, but that's my $0.02.

  Issac

PS - Apache::UploadMeter is now on CPAN.  The current distribution of it
comes bundled with a patch against libapreq-0.33  That's really, really,
really ugly.  Perhaps libapreq-0.34 is in order to at least get bug-fixes
out?


----- Original Message -----
From: "Joe Schaefer" <joe@sunstarsys.com>
To: <apreq-dev@httpd.apache.org>
Cc: "Stathy Touloumis" <stathy.touloumis@edventions.com>
Sent: Tuesday, January 08, 2002 8:11 AM
Subject: 5005thread patch (was Re: make failure for Apache::Request)


>
> [message forwarded to apreq-dev@httpd.apache.org - some content trimmed]
>
> "Stathy Touloumis" <stathy.touloumis@edventions.com> writes:
>
> > Hi,
> >
> > I wasn't able to send an email to apreq-dev@apache.org, kept bouncing
back.
> > I thought I would forward it to you in case you might be able to help.
> >
> > I was able to perform a successful build for libapreq-0.33 on :
> > #uname -a
> > Linux notebook 2.4.10 #1 Sun Dec 9 16:35:07 CST 2001 i686 unknown
> >
> > The patch is below in 'unified' format.  Please let me know if there is
> > documentation on standards for submitting patches etc.
> >
> > Thanks : )
> >
> > #perl -V
>
> [...]
>
> >     usethreads=define use5005threads=define useithreads=undef
>
> [...]
>
> > #diff -u Request.xs.OLD Request.xs
> > --- Request.xs.OLD      Mon Jan  7 11:07:51 2002
> > +++ Request.xs  Mon Jan  7 11:06:08 2002
> > @@ -192,6 +192,7 @@
> >
> >  static int upload_hook(void *ptr, char *buf, int len, ApacheUpload
*upload)
> >  {
> > +       dTHX;
> >      UploadHook *hook = (UploadHook *)ptr;
> >
> >      if (!(upload->fp && ApacheRequest_tmpfile(upload->req, upload)))
{
>
> Thanks, will apply shortly.  Maybe we should also bundle some feature
> tests (using Apache::test?) before going to 1.0?  Perhaps we should try
> adding some of the mod_perl test suite to (the perl portion of) libapreq.
>
> Thoughts, anyone?
> --
> Joe Schaefer
>


Mime
View raw message