Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
To: Maurice Aubrey <maurice@hevanet.com>
Subject: Re: patch to ignore blank cookie attributes
Cc: apreq-dev@httpd.apache.org
References: <20011207184120.A17765@hevanet.com>
From: Joe Schaefer <joe+apache@sunstarsys.com>
Date: 14 Dec 2001 22:52:53 -0500
In-Reply-To: Maurice Aubrey's message of "Fri, 7 Dec 2001 18:41:20 -0800"
Message-ID: <m3d71h6sx6.fsf@mumonkan.sunstarsys.com>
Lines: 23
User-Agent: Gnus/5.0802 (Gnus v5.8.2) Emacs/20.5
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Maurice Aubrey <maurice@hevanet.com> writes:

> --- c/apache_cookie.c.orig	Fri Dec  7 18:16:05 2001
> +++ c/apache_cookie.c	Fri Dec  7 18:16:32 2001
> @@ -188,7 +188,7 @@
>      *(char **)ap_push_array(arr) = (char *)val
>  
>  #define cookie_push_named(arr, name, val) \
> -    if(val) { \
> +    if(val && (strlen(val) > 0)) { \
>          cookie_push_arr(arr, ap_pstrcat(p, name, "=", val, NULL)); \
>      }

Thanks alot; I'm testing it now along with another patch that 
replaces line 177's ap_getword call with ap_getword_nulls;
that also seems to bring Apache::Cookie's behavior more in
step with CGI::Cookie. 

Will apply both patches RSN unless somebody objects.

-- 
Joe Schaefer