httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+apa...@sunstarsys.com>
Subject Re: patch to ignore blank cookie attributes
Date Sat, 15 Dec 2001 03:52:53 GMT
Maurice Aubrey <maurice@hevanet.com> writes:

> --- c/apache_cookie.c.orig	Fri Dec  7 18:16:05 2001
> +++ c/apache_cookie.c	Fri Dec  7 18:16:32 2001
> @@ -188,7 +188,7 @@
>      *(char **)ap_push_array(arr) = (char *)val
>  
>  #define cookie_push_named(arr, name, val) \
> -    if(val) { \
> +    if(val && (strlen(val) > 0)) { \
>          cookie_push_arr(arr, ap_pstrcat(p, name, "=", val, NULL)); \
>      }

Thanks alot; I'm testing it now along with another patch that 
replaces line 177's ap_getword call with ap_getword_nulls;
that also seems to bring Apache::Cookie's behavior more in
step with CGI::Cookie. 

Will apply both patches RSN unless somebody objects.

-- 
Joe Schaefer



Mime
View raw message