httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dav...@dedasys.com (David N. Welton)
Subject Re: patch to ignore blank cookie attributes
Date Tue, 18 Dec 2001 18:27:01 GMT
Joe Schaefer <joe+apache@sunstarsys.com> writes:

> Maurice Aubrey <maurice@hevanet.com> writes:
> 
> > --- c/apache_cookie.c.orig	Fri Dec  7 18:16:05 2001
> > +++ c/apache_cookie.c	Fri Dec  7 18:16:32 2001
> > @@ -188,7 +188,7 @@
> >      *(char **)ap_push_array(arr) = (char *)val
> >  
> >  #define cookie_push_named(arr, name, val) \
> > -    if(val) { \
> > +    if(val && (strlen(val) > 0)) { \
> >          cookie_push_arr(arr, ap_pstrcat(p, name, "=", val, NULL)); \
> >      }
> 
> Thanks alot; I'm testing it now along with another patch that 
> replaces line 177's ap_getword call with ap_getword_nulls;
> that also seems to bring Apache::Cookie's behavior more in
> step with CGI::Cookie. 
> 
> Will apply both patches RSN unless somebody objects.

Err, shoot, don't know if I've caught you in time, but it *should* be
possible to send blank cookies, no?  I recall mod_dtcl users
specifically requesting that they work.

-- 
David N. Welton
   Consulting: http://www.dedasys.com/
Free Software: http://people.debian.org/~davidw/
   Apache Tcl: http://tcl.apache.org/
     Personal: http://www.efn.org/~davidw/

Mime
View raw message