httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+apa...@sunstarsys.com>
Subject Re: [Patch] Fixes upload_hook error in Request.XS
Date Fri, 02 Nov 2001 03:48:55 GMT
"Issac Goldstand" <margol@beamartyr.net> writes:

> 196,197c197,198
> < 
> <     if (!(upload->fp && ApacheRequest_tmpfile(upload->req, upload)))
{
> ---
> >      
> >     if (!(ApacheRequest_tmpfile(upload->req, upload)) && (upload->fp))
{

Grr- deMoivre strikes again :(

The original looked something like

  if (upload->fp == NULL && !(Apache_request_tmpfile(upload->req, upload))

deMoivre's rule would make that equivalent to


  if ( !(upload->fp || Apache_request_tmpfile(upload->req, upload)) )


It looks like patch 1.20 introduced this bug ( || ~ && misconversion).
I'd rather patch using this last version (mainly to save a call to
Apache_request_tmpfile).  Could you verify that it works ok for you?

Thanks for tracking this down.
-- 
Joe Schaefer


Mime
View raw message