httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Issac Goldstand" <mar...@beamartyr.net>
Subject Re: [Patch] Fixes upload_hook error in Request.XS
Date Mon, 05 Nov 2001 17:17:42 GMT
Sorry it's taken so long to reply - I was a bit busy.  Anyway, it seems to
work fine using the || too...  I'm just a tad worried, becasue I don't have
my notes about this project around (most were done on a whiteboard) and I
have this nagging suspicion that I'd tried this and found the long way (if
{ if ) better, but I'm not 100% sure...

 Issac

Internet is a wonderful mechanism for making a fool of
yourself in front of a very large audience.
  --Anonymous

Moving the mouse won't get you into trouble...  Clicking it might.
  --Anonymous

PGP Key 0xE0FA561B - Fingerprint:
7E18 C018 D623 A57B 7F37 D902 8C84 7675 E0FA 561B




----- Original Message -----
From: "Joe Schaefer" <joe+apache@sunstarsys.com>
To: "Issac Goldstand" <margol@beamartyr.net>
Cc: <apreq-dev@httpd.apache.org>
Sent: Friday, November 02, 2001 5:48
Subject: Re: [Patch] Fixes upload_hook error in Request.XS


> "Issac Goldstand" <margol@beamartyr.net> writes:
>
> > 196,197c197,198
> > <
> > <     if (!(upload->fp && ApacheRequest_tmpfile(upload->req, upload)))
{
> > ---
> > >
> > >     if (!(ApacheRequest_tmpfile(upload->req, upload)) && (upload->fp))
{
>
> Grr- deMoivre strikes again :(
>
> The original looked something like
>
>   if (upload->fp == NULL && !(Apache_request_tmpfile(upload->req, upload))
>
> deMoivre's rule would make that equivalent to
>
>
>   if ( !(upload->fp || Apache_request_tmpfile(upload->req, upload)) )
>
>
> It looks like patch 1.20 introduced this bug ( || ~ && misconversion).
> I'd rather patch using this last version (mainly to save a call to
> Apache_request_tmpfile).  Could you verify that it works ok for you?
>
> Thanks for tracking this down.
> --
> Joe Schaefer
>


Mime
View raw message