httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From (David N. Welton)
Subject multiple files with the same name, .h file changes
Date Wed, 20 Jun 2001 14:45:26 GMT

I'd like to propose this, to stay consistent - if we have _find,
_type, _info, we might as well do them all.

--- /home/davidw/workshop/httpd-apreq/c/apache_request.h        Tue Jun 19 12:17:10 2001
+++ apache_request.h    Wed Jun 20 13:58:48 2001
@@ -105,6 +105,11 @@
 #define ApacheRequest_upload(req) \
     ((req->parsed || (ApacheRequest_parse(req) == OK)) ? req->upload : NULL)
+#define ApacheUpload_FILE(upload) (upload->fp)
+#define ApacheUpload_size(upload) (upload->size)
 #define ApacheUpload_info(upload, key) \
 ap_table_get(upload->info, key)

_FILE could be _fp too.  It's more consistent, but less descriptive.

Second thing... I'm puzzling over how to implement code to handle
multiple files uploaded with the same variable name.  It *is* legal,
and it's a pain in the ass.  apreq has some problems with it:

ApacheUpload *ApacheUpload_find(ApacheUpload *upload, char *name);

which will only get the first one.

I'd be curious to hear, briefly, how you perl guys deal with this, as
well as if you have any ideas on how we can (if needs be) improve
apreq to support this.

David N. Welton
Free Software:
   Apache Tcl:

View raw message